fix: DocumentFragment#path
with libxml > 2.9.10
#2251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Fixes #2250 which describes a segfault when calling
DocumentFragment#path
with libxml > 2.9.10.Have you included adequate test coverage?
Yes. Introduced test coverage for both
DocumentFragment#path
andDocument#path
Does this change affect the behavior of either the C or the Java implementations?
This maintains the behavior of the C extension across versions of libxml2. That, however, doesn't mean that the behavior makes sense, and we should fix it when we're ready to introduce breaking changes into
DocumentFragment#xpath
.