Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce html4 namespace #2278

Merged
merged 6 commits into from
Jun 21, 2021
Merged

introduce html4 namespace #2278

merged 6 commits into from
Jun 21, 2021

Commits on Jun 21, 2021

  1. doc: import Nokogumbo's README as Nokogiri::HTML5 doc string 

    also make private HTML5::Node#add_child_node_and_reparent_attrs
    @flavorjones
    flavorjones committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    99781f4 View commit details
    Browse the repository at this point in the history

  2. use require_relative instead of require 

    see https://bugs.ruby-lang.org/issues/8781 which recommends this
change.
    @flavorjones
    flavorjones committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    0cee8f0 View commit details
    Browse the repository at this point in the history

  3. refactor: rename HTML namespace to HTML4 

    and make HTML an alias to HTML4.

- renamed files, C and Java variables, and Java class names
- updated gemspec
- updated doc strings
- updated usage in lib/ and ext/ to specify HTML4
- added a test asserting on equality of identity of the modules

Notably, left the tests alone to ensure this isn't a breaking change.
    @flavorjones
    flavorjones committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    6995682 View commit details
    Browse the repository at this point in the history

  4. doc(yard): omit needless info from generated docs

    @flavorjones
    flavorjones committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e723fdb View commit details
    Browse the repository at this point in the history

  5. update CHANGELOG with HTML4 module information

    @flavorjones
    flavorjones committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e52ec9d View commit details
    Browse the repository at this point in the history

  6. deprecated: Nokogiri::HTML5.get

    @flavorjones
    flavorjones committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    4ac9350 View commit details
    Browse the repository at this point in the history