Remove outdated comments #2339
Merged
Remove outdated comments #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first comment is incorrect. The fragment case was changed to match the nonfragment case in whatwg/html#6399. This introduced a bug that was noted by the second comment indicating that the parser diverged from the standard to fix the bug. The standard was subsequently fixed in whatwg/html#6455, obviating the comment.
flavorjones
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
There are outdated comments in the code. The standard changed and the comments either reflected an earlier version of the standard or described how the standard was going to change.
The first comment is incorrect. The fragment case was changed to match
the nonfragment case in whatwg/html#6399.
The outdated comments were discovered while investigating #2335.
Have you included adequate test coverage?
There is no functional change and no tests were added.
Does this change affect the behavior of either the C or the Java implementations?
Neither.