fix: memory leak in Reader#base_uri #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clean up that function.
flavorjones
force-pushed
the
flavorjones-reader-base-uri-memory-leak
branch
from
bdd597e
to
68c1911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Playing with ruby_memcheck led to finding a few easy-to-fix memory leaks.
Reader#base_uriwas not freeing the string returned byxmlTextReaderBaseUri()This PR also cleans up the Reader C function.
Have you included adequate test coverage?
#2344 is a parallel effort to automate the leak checking that I ran on the existing test suite to find these.