/ nokogiri Public
SAX::Parser constructors check types (v1.13.x branch) #2530
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
What problem is this PR intended to solve?
HTML4::SAX::Parser, HTML4::SAX::ParserContext, XML::SAX::Parser, and XML::SAX::ParserContext now properly check the types of the arguments to their various constructor methods.
Previously, passing arguments of unexpected types might cause a segfault or other less-obvious exceptions.
This is a backport of #2529
Have you included adequate test coverage?
Yes! Added test coverage for these cases.
Does this change affect the behavior of either the C or the Java implementations?
Both the C and Java implementations have been updated to behave identically in this circumstance.