Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix development dependency breakage #2618

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Aug 7, 2022

What problem is this PR intended to solve?

Because of jruby/jruby#7262 let's pin jar-dependencies to 0.4.1

Because of ruby/setup-ruby#358 let's explicitly opt into latest bundler in all CI jobs

@flavorjones flavorjones force-pushed the flavorjones-loosen-bundler-dependency branch from ab20796 to 3140b00 Compare August 7, 2022 21:46
because jruby 9.3.6.0 has jar-dependencies 0.4.0 as a default gem and
jruby/jruby#7262 describes a problem
overriding that default version.

this can be undone (loosened) once the problem is fixed upstream
@flavorjones flavorjones force-pushed the flavorjones-loosen-bundler-dependency branch from 3140b00 to 952d9e4 Compare August 7, 2022 21:58
@flavorjones flavorjones changed the title dep(dev): loosen bundler dependency ci: fix development dependency breakage Aug 7, 2022
@flavorjones flavorjones merged commit afe634a into main Aug 8, 2022
@flavorjones flavorjones deleted the flavorjones-loosen-bundler-dependency branch August 8, 2022 01:41
p8 added a commit to p8/sdoc that referenced this pull request Aug 8, 2022
Should fix the following error:

    Run bundle exec rake
    bundler: failed to load command: rake (/home/runner/work/sdoc/sdoc/vendor/bundle/jruby/3.1.0/bin/rake)
    Gem::LoadError: You have already activated jar-dependencies 0.4.1, but your Gemfile requires jar-dependencies 0.4.2. Since jar-dependencies is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports jar-dependencies as a default gem.

Fix is similar to:
  sparklemotion/nokogiri#2618
p8 added a commit to p8/sdoc that referenced this pull request Aug 8, 2022
Should fix the following error:

    Run bundle exec rake
    bundler: failed to load command: rake (/home/runner/work/sdoc/sdoc/vendor/bundle/jruby/3.1.0/bin/rake)
    Gem::LoadError: You have already activated jar-dependencies 0.4.1, but your Gemfile requires jar-dependencies 0.4.2. Since jar-dependencies is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports jar-dependencies as a default gem.

Fix is similar to:
  sparklemotion/nokogiri#2618

The Ubuntu update should make sure we have the correct Rubygems version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant