improve exception handling in xpath evaluation #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Avoid raising Ruby exceptions from within libxml2 error callbacks while evaluating xpath queries in
xmlXPathEvalExpression. Instead, collect them in an array and raise an exception afterxmlXPathEvalExpressionreturns.Partly addresses #1610.
I've also cleaned up xml_xpath_context.c a bit while I was in there.
Have you included adequate test coverage?
Existing test coverage is appropriate.
Does this change affect the behavior of either the C or the Java implementations?
The only behavior change is for C to match JRuby's exception type when an xpath function can't be found. The test has been updated to remove the conditional on engine.