fix: XML::Reader error handling during xmlTextReaderExpand #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-fix-reader-error-handling_main
branch
from
e0dcf1c
to
549ac3a
Compare
flavorjones
force-pushed
the
flavorjones-fix-reader-error-handling_main
branch
from
549ac3a
to
86b1c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
XML::Readerparsing errors encountered duringReader#attribute_hashandReader#namespacesnow raise anXML::SyntaxError.Previously these methods would return
niland users would generally experienceNoMethodErrorsfrom elsewhere in the code.Have you included adequate test coverage?
Test coverage added.
Does this change affect the behavior of either the C or the Java implementations?
The C and Java parsers differ in when they detect a syntax error in this case. libxml2 indicates an error when we try to expand a start tag that does not have a matching end tag, but xerces will defer the error until later. The tests reflect that difference.