Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate HTM4::ElementDescription to TypedData #2821

Conversation

casperisfine
Copy link

Ref: #2808

Since it has no mark function, we can enable write barrier without changing any code.

cc @flavorjones @etiennebarrie

Ref: sparklemotion#2808

Since it has no mark function, we can enable write barrier without changing
any code.
@flavorjones
Copy link
Member

Looks good! Thanks.

(Side note: this morning I briefly looked into avoiding a T_DATA struct entirely, and just calling htmlLookupTag every time we need to access it, but that function does a binary search using string comparisons ... I didn't benchmark but it feels less efficient than just dereferencing a pointer.)

@flavorjones flavorjones merged commit f7aa3b0 into sparklemotion:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants