feat: gumbo support for hr in select
#2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the hr-in-select tests
where before we saw:
TestHtml5TreeConstructionWebkit02#test_31 [/home/flavorjones/code/oss/nokogiri/test/html5/test_tree_construction.rb:35]
Minitest::Assertion: Element <select><option><hr></option></select> has wrong number of children ["option"] in <table><tr><td><select><option><hr>.
Expected: 2
Actual: 1
now we'll see:
TestHtml5TreeConstructionWebkit02#test_31 [/home/flavorjones/code/oss/nokogiri/test/html5/test_tree_construction.rb:35]
Minitest::Assertion: Element <select> has wrong number of children ["option"]
Input: <table><tr><td><select><option><hr>
Expected: | <html>
| <head>
| <body>
| <table>
| <tbody>
| <tr>
| <td>
| <select>
| <option>
| <hr>
Parsed: <select><option><hr></option></select>.
Expected: 2
Actual: 1
flavorjones
force-pushed
the
flavorjones-gumbo-hr-in-select
branch
from
b91078e
to
68ededf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
feat: gumbo support for
<hr>in<select>The text added to the parser spec, under "in select" insertion mode, is:
Also improve gumbo tree construction test failure messages.
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
The HTML5 parser is only available in CRuby.