exchange string and regexp in assert_match tests #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniTest gem raises a TypeError TypeError: can't convert Regexp to String when in assert_match the first argument is a string and the second a regular expression, as the first argument is always converted to RegExp.
leejarvis
added a commit
that referenced
this pull request
May 14, 2013
exchange string and regexp in assert_match tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
MiniTest gem raises a TypeError
TypeError: can't convert Regexp to String
when in assert_match the first argument is a string and the second a
regular expression, as the first argument is always converted to RegExp.
Note that this does not happen with the version of minitest shipped with ruby1.9.3, and has occured with the gem since the following commit in minitest:
minitest/minitest@46a2bc3
This patch changes the order so that in assert_match, at least one of the operands in =~ is a String.
Cheers,
Cédric