Support default transaction mode. #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masamitsu-murase Thank you for suggesting this feature! I'm not familiar with how the Rails adapter is evolving, but this seems like a reasonable change. I've kicked off CI. |
|
Thank you so much! |
* Add "default_transaction_mode" to "options" parameter of SQLite3::Database.new. It is used as transaction mode when SQLite3::Database#transaction is called without "mode" argument.
flavorjones
force-pushed
the
support_default_transaction_mode
branch
from
34ff624
to
109b6b1
Compare
|
@masamitsu-murase I've rebased onto |
which includes the new :default_transaction_mode
4 tasks
|
Link to related upstream rails discussion: rails/rails#49849 |
rubys
added a commit
to rubys/showcase
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me propose a default transaction mode, which is used as a transaction mode when
modeargument ofSQLite3::Database#transactionis omitted.This pull request does not break compatibility with the current version because the default value of
default_transaction_modeis:deferred.Usage:
This pull request also enables us to set the default transaction mode to
IMMEDIATEorEXCLUSIVEin rails.Regards,
Murase