Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPIC] Chat panel behavior #1392

Open
yarikoptic opened this issue May 14, 2021 · 5 comments
Open

[EPIC] Chat panel behavior #1392

yarikoptic opened this issue May 14, 2021 · 5 comments
Assignees
@0xdevalias @sofisparkle
Labels
Epic 💪 enhancement Enhancements/improvements to existing functionality

Comments

@yarikoptic
Copy link
Contributor

yarikoptic commented May 14, 2021 •
edited by 0xdevalias

Related PR #1311 / 🔒 https://github.com/sparkletown/internal-sparkle-issues/issues/622 is augmenting chat panel to be pinnable (on big screens) which would indeed be nice. It seems to need more testing and mitigate some issues, but if resizing to be developed, quite likely it might better be on top of that PR? May be @soichih has a quick idea on how to add resizing capability?
@0xdevalias 0xdevalias self-assigned this May 15, 2021
@soichih
Copy link
Contributor

soichih commented May 15, 2021

How about something like this?

2021-05-15.00-08-46.mp4

soichih added a commit to soichih/sparkle that referenced this issue May 15, 2021
@soichih
Made ChatSidebar resizable sparkletown#1392
750de5d
@0xdevalias 0xdevalias added the 💪 enhancement Enhancements/improvements to existing functionality label May 15, 2021
@0xdevalias
Copy link
Contributor

0xdevalias commented May 15, 2021 •
edited

How about something like this?

That looks pretty neat! How'd you go about implementing it out of curiosity?

From your video, it looks like this is being implemented on the 'floating' sidebar version, rather than the 'pinned' sidebar version implemented in #1311

Would your method work the same for the pinned version as well?

@yarikoptic
Copy link
Contributor Author

FWIW, AFAIK the implementation used in the demo is back referenced above soichih@750de5d . And AFAIK yes -- it is for current implementation in staging, thus a floating one, since pinned one from #1311 is not yet merged and its ETA is not yet known.

@yarikoptic yarikoptic mentioned this issue May 17, 2021
Merged
yarikoptic pushed a commit to yarikoptic/sparkle that referenced this issue May 19, 2021
@soichih @yarikoptic
Made ChatSidebar resizable sparkletown#1392
c6ecfea
@yarikoptic yarikoptic mentioned this issue May 19, 2021
Closed
yarikoptic added a commit to yarikoptic/sparkle that referenced this issue May 26, 2021
@yarikoptic
Merge branch 'enh-resize-chat' into my-ohbm
bd44809 
* enh-resize-chat:
  Replaced custom resizer component with re-resizable
  Made ChatSidebar resizable sparkletown#1392
@0xdevalias 0xdevalias mentioned this issue May 27, 2021
Open
@yarikoptic yarikoptic mentioned this issue Jun 10, 2021
Open
@mobilevinay
Copy link

As discussed, we perhaps refactor this issue or merge it into the one about "thinking about chat panel" behavior and have a good think about it.

@mobilevinay
Copy link

migrated to zenhub, check!

@mobilevinay mobilevinay changed the title Make chat panel resizable [EPIC] Chat panel behabior Jun 28, 2021
@mobilevinay mobilevinay changed the title [EPIC] Chat panel behabior [EPIC] Chat panel behavior Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xdevalias 0xdevalias

@sofisparkle sofisparkle

Labels
Epic 💪 enhancement Enhancements/improvements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow ChatSidebar width to be resized yarikoptic/sparkle
5 participants
@yarikoptic @0xdevalias @soichih @mobilevinay @sofisparkle