This repository has been archived by the owner on Oct 18, 2019. It is now read-only.
Configure self-signed certs #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treygriffith
force-pushed
the
gateway-certs
branch
from
f6d57fa
to
6823275
Compare
dannypaz
reviewed
Apr 7, 2019
.circleci/config.yml
Outdated
| - restore_cache: | ||
| keys: | ||
| - v3-dependencies-{{ checksum "package.json" }} | ||
| # - restore_cache: |
There was a problem hiding this comment.
@treygriffith probably didnt mean to check this in
There was a problem hiding this comment.
I did in fact mean to check this in because circle cache was failing. I'm considering removing the cache altogether. Talk me off the edge.
There was a problem hiding this comment.
@treygriffith lol we have had all kinds of issue with the caching. Looks like the best we can do right now is:
- make sure npm is updated (6.9.x)
- remove the lock and push the change
- add the lock file back and push the change
dannypaz
approved these changes
Apr 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we use self-signed certificates with the Broker we need to configure the internal proxy differently than if they are issued by e.g. LetsEncrypt.
This adds a new configuration for self-signed certificates to make either work.
Related PRs
#470
Todos