Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net-Curl test failures on FreeBSD 9.2 (cookies related) #7

Closed
eserte opened this issue Nov 24, 2013 · 1 comment
Closed

Net-Curl test failures on FreeBSD 9.2 (cookies related) #7

eserte opened this issue Nov 24, 2013 · 1 comment
Assignees

Comments

@eserte
Copy link
Contributor

eserte commented Nov 24, 2013

The Net-Curl testsuite fails for FreeBSD 9.2, see http://matrix.cpantesters.org/?dist=Net-Curl;os=freebsd;reports=1
The reason is that the standard freebsd 9.2 libcurl package is compiled without cookies support. This will be fixed for future freebsd versions (see http://www.freshports.org/ftp/curl/, the Changelog entry from 06 Oct 2013 18:36:49 says "Turn COOKIES on by default"). I just rebuild libcurl from ports with COOKIES turned on manually, and since then Net-Curl passes on my machine.

Probably there should be a feature check if cookies support is activated, and depending on this some tests should be skipped?

@creaktive
Copy link
Collaborator

Thanks for checking this!
I thought about skipping the cookie-related tests when the cookie feature is missing. However, there's potential caveat here: the modules/scripts that depend on Net::Curl don't usually make that check! I believe it is a common practice to blindly assume that cookies are properly handled in any HTTP user agent. So, explicitly failing when cookies feature is missing is probably a good thing.
On the other side, it took me a while to figure out the origin of that error.
I am thinking about adding a new test to check the presence of the cookie feature. If it is missing, the test will fail with some reasonable message. It should be up to the user if he/she can trust the module despite the missing pieces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants