Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-639] Switch to pip for dependency management #8

Merged
merged 10 commits into from
Sep 28, 2022
Merged

[SC-639] Switch to pip for dependency management #8

merged 10 commits into from
Sep 28, 2022

Conversation

jbencook
Copy link
Contributor

I like Poetry. But the safety we get from locking all dependencies is costing us too much development time. Instead, I'm proposing to switch back to pip-based installations.

Some problems:

  • Adding a Python package to the environment can take upwards of 5-10 minutes
  • Some dependencies fail to resolve entirely (I'm looking at you boto3)
  • Some random package in the dependency tree can mess up the entire process. This PEP 440 error has been hurting us for a few weeks now.

Here's a public repo where we've successfully switched to pip. This PR codifies the change to make it standard for future pattern updates across our projects.

I'm pretty sure this will work well for us, but I am curious if you have any opinion about pip vs poetry @kevinbird15.

@jbencook jbencook merged commit 1b34361 into main Sep 28, 2022
@jbencook jbencook deleted the pip-deps branch September 28, 2022 22:12
@kevinbird15
Copy link
Contributor

I like this idea, but I never really utilized poetry so I can't really claim I did due diligence on that tool. Always good with pip though. My understanding is that you are using the setup.cfg to handle dependencies then, right?

sparrow_patterns/dependencies/templates/setup.cfg
image

@jbencook
Copy link
Contributor Author

jbencook commented Oct 5, 2022

Yeah that's right. Not totally sure if that's the best way going forward, but that's how we're doing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants