Glarity is causing javascript error on every other website

[reorx]

Describe the bug
Glarity is causing javascript error on every other website that is not in the supported site list, including but not limited to:

• https://news.ycombinator.com/
• https://www.producthunt.com/
• https://threadreaderapp.com/

Desktop (please complete the following information):

• OS: MacOS
• Browser: Chrome

---

You are injecting content script on every website

   "content_scripts": [ {
      "css": [ "content-script.css" ],
      "js": [ "content-script.js" ],
      "matches": [ "\u003Call_urls>", "*://*/*" ]
   } ],

This is understandable because the websites Glarity supports are extensible, and matching sites in the manifest is too much hassle.

But you should enhance the code to change irrelevant pages as little as possible. I believe this error is caused by not checking whether the site is in the supported site list and assuming something should be there to proceed.

Also, I think you should avoid injecting css this way. It's uncontrollable, you should let the content-script.js inject the css after checking it is a supported site.

[givebest]

@reorx Please tell me which version you are using.

[reorx]

Version 1.1.7

…

On Mar 29, 2023 at 15:37:26, givebest ***@***.***> wrote: @reorx <https://github.com/reorx> Please tell me which version you are using. — Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDDVEZLGGLDP4D3FJ5XPTW6PRDNANCNFSM6AAAAAAWLRXT3M> . You are receiving this because you were mentioned.Message ID: ***@***.*** .com>

[givebest]

You can try our beta version, which fixes this issue and adds many new features. https://github.com/sparticleinc/chatgpt-google-summary-extension/tree/beta/packages