Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units of compartment area/volume in reaction rates #584

Closed
lkeegan opened this issue Jun 21, 2021 · 1 comment · Fixed by #593
Closed

units of compartment area/volume in reaction rates #584

lkeegan opened this issue Jun 21, 2021 · 1 comment · Fixed by #593
Labels
bug Something isn't working integration Integration with other software SBML SBML and libSBML

Comments

@lkeegan
Copy link
Member

lkeegan commented Jun 21, 2021

Currently, when a reaction rate equation references the name of a compartment, it uses the numerical value of the volume in units of L^3 or L^2.

In the case of reactions imported from COPASI, typically this factor is symbolically removed on import, but depending on COPASI user choices for membrane reactions it may not be, and it should then be in units of VOLUME, not LENGTH^3, to preserve the behaviour of the model. (thanks @baronvonderheyden)

Todo:

  • probably compartments should be in units of volume in reaction rates
  • probably membranes are correct as L^2
  • confirm the above
@lkeegan lkeegan added bug Something isn't working SBML SBML and libSBML integration Integration with other software labels Jun 21, 2021
@lkeegan
Copy link
Member Author

lkeegan commented Jun 24, 2021

Also, related to #588 , the size and units attributes of the compartment or membrane in SBML should be consistent with the above.

lkeegan added a commit that referenced this issue Jul 5, 2021
- add depth to geometry image dialog
- resolves #582

use/display compartment/membrane sizes in correct units

- use volume units for Compartment sizes
- use area units for Membrane sizes
- resolves #584
lkeegan added a commit that referenced this issue Jul 5, 2021
- add depth to geometry image dialog
- resolves #582

use/display compartment/membrane sizes in correct units

- use volume units for Compartment sizes
- use area units for Membrane sizes
- resolves #584
lkeegan added a commit that referenced this issue Jul 5, 2021
- add depth to geometry image dialog
- resolves #582

use/display compartment/membrane sizes in correct units

- use volume units for Compartment sizes
- use area units for Membrane sizes
- resolves #584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration Integration with other software SBML SBML and libSBML
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant