Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python sme compartment geometry mask not updated #630

Closed
lkeegan opened this issue Aug 23, 2021 · 0 comments
Closed

python sme compartment geometry mask not updated #630

lkeegan opened this issue Aug 23, 2021 · 0 comments
Labels
bug Something isn't working python Python library

Comments

@lkeegan
Copy link
Member

lkeegan commented Aug 23, 2021

Describe the bug
If a new compartment geometry image is set, the compartment geometry masks are not updated
@lkeegan lkeegan added bug Something isn't working python Python library labels Aug 23, 2021
lkeegan added a commit that referenced this issue Aug 23, 2021
@lkeegan
optionally keep existing compartment colours on image resize
b338347 
- ModelGeometry::importGeometryFromImage: add keepColourAssignments option
- DialogGeometryImage: separate imageSizeAltered() and imageColoursAltered()
- ModelCompartments::setColour: now a no-op if no pixels of that colour in image
- refactor python sme to use this functionality
- resolves #587

also fix related bug

- update compartment geometry mask in python sme when geometry image changes
- fix indentation of relevant test so it is included in the test suite
- resolves #630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working python Python library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lkeegan