Scene graph integration #991

nashmit · 2024-05-16T20:42:16Z

A clear split between updating and drawing each object based on the interface.

for more information, see https://pre-commit.ci

…form.

…nalytical form. Apply global transformation to analytical plan equation.

…ial and fromVectorialToAnalytical

…fter the GPU memory is deallocated.

codecov · 2024-05-16T21:03:05Z

Codecov Report

Attention: Patch coverage is 95.13514% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.53%. Comparing base (95189d2) to head (b356e99).
Report is 1 commits behind head on main.

Files	Patch %	Lines
gui/widgets/qopenglmousetracker.cpp	87.50%	7 Missing ⚠️
gui/rendering/Node.cpp	97.18%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   88.99%   89.53%   +0.54%     
==========================================
  Files         144      144              
  Lines       14469    14520      +51     
==========================================
+ Hits        12876    13001     +125     
+ Misses       1593     1519      -74

Flag	Coverage Δ
cli	`22.09% <0.00%> (-0.08%)`	⬇️
core	`49.11% <0.00%> (-0.18%)`	⬇️
gui	`70.83% <95.13%> (+0.61%)`	⬆️
mainwindow	`40.98% <20.65%> (+0.30%)`	⬆️
sme	`28.05% <0.00%> (-0.10%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gui/rendering/Config.h

gui/rendering/Node.cpp

lkeegan

Thanks - just a few minor comments - let me know when the complete PR is ready for review

gui/rendering/Camera.hpp

gui/rendering/Node.hpp

gui/widgets/qopenglmousetracker.cpp

lkeegan

QOpenGLMouseTracker has a number of functions that aren't used, but I guess they will be in the future?

gui/rendering/Node.hpp

gui/rendering/Node.cpp

gui/rendering/WireframeObjects.hpp

nashmit · 2024-05-29T12:22:24Z

QOpenGLMouseTracker has a number of functions that aren't used, but I guess they will be in the future?

Yes. If not, I will delete them.

lkeegan

thanks lgtm

sonarcloud · 2024-05-29T14:05:11Z

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nashmit and others added 30 commits May 7, 2024 15:48

Adding Scene Graph Node class

b18e317

Camera now extends Node and can be used inside a Scene Graph

c9148d0

WireframeObjects now extends Node and can be used inside a Scene Graph

cdb4c90

[pre-commit.ci] auto fixes from pre-commit.com hooks

751cfe1

for more information, see https://pre-commit.ci

ClippingPlane now extends Node and can be used inside a Scene Graph

8023f18

Unused variable deleted.

29b7ed5

Add function to transform the analytical plane equation to vectorial …

9a8427a

…form.

Switch off GPU information prints.

9e38f4f

Add a function to transform the vector plane representation into an a…

6246c0a

…nalytical form. Apply global transformation to analytical plan equation.

add GetClipPlane() function

72194e8

Add test for GetClipPlane, and implicitly, for fromAnalyticalToVector…

ed4e26f

…ial and fromVectorialToAnalytical

Switch off context change when DestroyVBO is called

4bf3f6a

Fix Sonar warnings.

b920fdf

Opengl Context switching off

2906be2

Fix plane, local space transformation.

1ba4eef

Refactoring TranslateClipPlane().

512c11a

Add debug loging for QOpenGLMouseTracker::clear().

8aadb4e

Fix inaccessible name variable.

d76ce79

Fix parameter missing.

7ba1a3f

Add TODO: Implement use case note with transform in global coordinates.

508d663

Fix typo

b2e4f45

Changing the inheritance order s.t. the OpenGL context is destroyed a…

0944a01

…fter the GPU memory is deallocated.

switch assert condition

57171d8

Fix OpenGL context distribution order.

2aa3597

Merge branch 'main' into scene_graph

cbc8de7

Fix rotationMatrixToEulerAngles() euler angle computation.

4b93c81

Delete debug log print.

246466d

Change debug log print format.

ad6a77a

Updating node removing method.

3bbb7f7

Add comment for incomplete feature.

8e682da

nashmit linked an issue May 16, 2024 that may be closed by this pull request

A clear split between updating and drawing each object based on the interface #989

Closed

lkeegan reviewed May 17, 2024

View reviewed changes

gui/rendering/Config.h Outdated Show resolved Hide resolved

gui/rendering/Node.cpp Outdated Show resolved Hide resolved

nashmit added 11 commits May 17, 2024 12:28

Change extension.

fbcfcba

Partially adaption of the rendering system to a scene graph system.

17d1ad3

Adapting opengl widget to scene graph flow, continuation.

9d58d31

Adapting opengl widget to scene graph flow, continuation.

fc1ca24

Adapting opengl widget to scene graph flow, continuation.

fbecc01

Adapting opengl widget to scene graph flow, continuation.

03887d1

Adapting opengl widget to scene graph flow, continuation.

cf8580a

Check if m_SubMeshes exists.

a87f4d3

Add const

9905dc1

Adapting opengl widget to scene graph flow, continuation.

4e81f1a

Merge branch 'main' into scene_graph_split_update_draw

8683573

nashmit requested a review from lkeegan May 27, 2024 12:57

lkeegan reviewed May 27, 2024

View reviewed changes

gui/rendering/Camera.hpp Outdated Show resolved Hide resolved

gui/rendering/Node.hpp Outdated Show resolved Hide resolved

gui/widgets/qopenglmousetracker.cpp Outdated Show resolved Hide resolved

nashmit added 3 commits May 28, 2024 22:04

Code cleaning.

2103e43

Clean code and add consts.

1a0f486

Add const

d4839b1

nashmit requested a review from lkeegan May 28, 2024 21:59

nashmit self-assigned this May 28, 2024

Matrix transformation, quick fix.

7ddbcc8

lkeegan reviewed May 29, 2024

View reviewed changes

Switch from shared_ptr to weak_ptr or reference.

b356e99

nashmit requested a review from lkeegan May 29, 2024 13:42

lkeegan approved these changes May 29, 2024

View reviewed changes

nashmit merged commit 1cc6177 into main May 29, 2024
19 checks passed

nashmit deleted the scene_graph_split_update_draw branch May 29, 2024 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scene graph integration #991

Scene graph integration #991

nashmit commented May 16, 2024

codecov bot commented May 16, 2024 •

edited

lkeegan left a comment

lkeegan left a comment

nashmit commented May 29, 2024

lkeegan left a comment

sonarcloud bot commented May 29, 2024

Scene graph integration #991

Scene graph integration #991

Conversation

nashmit commented May 16, 2024

codecov bot commented May 16, 2024 • edited

Codecov Report

lkeegan left a comment

Choose a reason for hiding this comment

lkeegan left a comment

Choose a reason for hiding this comment

nashmit commented May 29, 2024

lkeegan left a comment

Choose a reason for hiding this comment

sonarcloud bot commented May 29, 2024

Quality Gate passed

codecov bot commented May 16, 2024 •

edited