Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Deployment Launcher docs #941

Merged
merged 11 commits into from
May 14, 2019
Merged

Deployment Launcher docs #941

merged 11 commits into from
May 14, 2019

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented May 13, 2019

Description

deployment launcher docs - DM me for preview link

Tests

improbadoc serve

Documentation

this is the docs

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

Jamie Brynes and others added 5 commits May 1, 2019 18:35
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
@improbable-prow-robot improbable-prow-robot added T: documentation Type: This is related to documentation size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. labels May 13, 2019
@paulbalaji paulbalaji requested review from jamiebrynes7, zeroZshadow and jessicafalk and removed request for NotRobSheridan and ElleEss May 13, 2019 16:03
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
docs/modules/deployment-launcher/overview.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/upload-assemblies.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/upload-assemblies.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/upload-assemblies.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/upload-assemblies.md Outdated Show resolved Hide resolved
docs/projects/fps/get-started/upload-launch.md Outdated Show resolved Hide resolved
docs/projects/fps/get-started/upload-launch.md Outdated Show resolved Hide resolved
docs/projects/fps/get-started/upload-launch.md Outdated Show resolved Hide resolved
docs/projects/fps/get-started/upload-launch.md Outdated Show resolved Hide resolved
paulbalaji and others added 3 commits May 14, 2019 11:45
Co-Authored-By: jessicafalk <31853332+jessicafalk@users.noreply.github.com>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Copy link
Contributor

@jessicafalk jessicafalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments, but overall lgtm

docs/modules/deployment-launcher/upload-assemblies.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/launch-deployments.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/launch-deployments.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/launch-deployments.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/manage-deployments.md Outdated Show resolved Hide resolved
docs/modules/deployment-launcher/manage-deployments.md Outdated Show resolved Hide resolved
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
@paulbalaji paulbalaji mentioned this pull request May 14, 2019
19 tasks
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
@paulbalaji paulbalaji merged commit 779522c into docs-next May 14, 2019
@paulbalaji paulbalaji deleted the docs/deployment-launcher branch May 14, 2019 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 300-599 lines, ignoring generated files. T: documentation Type: This is related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants