This repository has been archived by the owner on Jun 1, 2019. It is now read-only.
Added possibility to fall back to a default user id #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll review your changes this weekend. If all is good, I'll merge it and tag a new version. |
|
👍 |
freekmurze
added a commit
that referenced
this pull request
May 21, 2015
Added possibility to fall back to a default user id
|
I've taken a look at your code a bit earlier than anticipated. In general your changes were good. I've refactored `normalizedUserId' a little bit. If prefer early returns over else-branches. All changes are included in the newly tagged version 2.1.0 |
|
Looks good! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #9.