This repository has been archived by the owner on Jun 1, 2019. It is now read-only.
Use user identifier accessors if applicable #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, the tests seem to fail for this PR. I'm currently working on the next major release of this package. When it comes out (in the coming weeks) this package will be marked as abandoned. |
|
Hi, this package has been abandoned. Please use laravel-activitylog instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more robust (tests are not updated).
Also, you should really update the dependencies in
composer.json, as the package is using components ofilluminate/configandilluminate/database. Moreover, the package assumes that Laravel's shipped default aliases are still present (e.g.Eloquent,Config,Log). IMHO packages are better off to use the Facade directly.