Rewrite phpunit tests to pest #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Mar 9, 2022
src/ArrayToXml.php
Outdated
| @@ -26,7 +26,9 @@ public function __construct( | |||
| array $domProperties = [], | |||
| ?bool $xmlStandalone = null | |||
| ) { | |||
| $this->document = new DOMDocument($xmlVersion, $xmlEncoding); | |||
| $this->document = $xmlEncoding === null ? | |||
There was a problem hiding this comment.
This seems like a functional change. Could you revert all changes to this file?
There was a problem hiding this comment.
Reverted it. Sorry, I'm running PHP 8.1...just checked, it works on PHP 8.0.
freekmurze
requested changes
Mar 9, 2022
Also fix problems because null as second argument for DOMDocument and as argument for htmlspecialchars is deprecated. Further update PHP CS Fixer setup.
|
Thanks! |
weirdan
added a commit
to weirdan/array-to-xml
that referenced
this pull request
Dec 13, 2022
This will help backporting changes from main branch
freekmurze
pushed a commit
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix problems because null as second argument for DOMDocument and
as argument for htmlspecialchars is deprecated. Further update PHP CS
Fixer setup.