Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addXmlDeclaration parameter #216

Merged
merged 2 commits into from
May 11, 2023
Merged

Add addXmlDeclaration parameter #216

merged 2 commits into from
May 11, 2023

Conversation

silnex
Copy link
Contributor

@silnex silnex commented May 11, 2023

Improve usability of the addXmlDeclaration parameter 馃槃

before

<?php
$xml = (new ArrayToXml($arr))->dropXmlDeclaration()->toXml();

after

<?php
$xml = ArrayToXml::convert($arr, addXmlDeclaration: false);

@freekmurze freekmurze merged commit e210b98 into spatie:main May 11, 2023
7 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@silnex @freekmurze