Prevent double request interception on POST

spatie · Aug 19, 2022 · 7125719 · 7125719
1 parent 9e93f0c
commit 7125719
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 17 deletions.
diff --git a/bin/browser.js b/bin/browser.js
@@ -101,23 +101,6 @@ const callChrome = async pup => {
 
         await page.setRequestInterception(true);
 
-        if (request.postParams) {
-            const postParamsArray = request.postParams;
-            const queryString = Object.keys(postParamsArray)
-                .map(key => `${key}=${postParamsArray[key]}`)
-                .join('&');
-            page.once("request", interceptedRequest => {
-                interceptedRequest.continue({
-                    method: "POST",
-                    postData: queryString,
-                    headers: {
-                        ...interceptedRequest.headers(),
-                        "Content-Type": "application/x-www-form-urlencoded"
-                    }
-                });
-            });
-        }
-
         const contentUrl = request.options.contentUrl;
         const parsedContentUrl = contentUrl ? contentUrl.replace(/\/$/, "") : undefined;
         let pageContent;
@@ -195,6 +178,22 @@ const callChrome = async pup => {
                 }
             }
 
+            if (request.postParams) {
+                const postParamsArray = request.postParams;
+                const queryString = Object.keys(postParamsArray)
+                    .map(key => `${key}=${postParamsArray[key]}`)
+                    .join('&');
+                interceptedRequest.continue({
+                    method: "POST",
+                    postData: queryString,
+                    headers: {
+                        ...interceptedRequest.headers(),
+                        "Content-Type": "application/x-www-form-urlencoded"
+                    }
+                });
+                return;
+            }
+
             interceptedRequest.continue({ headers });
         });
 

diff --git a/tests/BrowsershotTest.php b/tests/BrowsershotTest.php
@@ -980,6 +980,14 @@
     ], $command);
 });
 
+it('can process post request', function () {
+    $html = Browsershot::url('https://httpbin.org/post')
+        ->post(['foo' => 'bar'])
+        ->bodyHtml();
+
+    expect($html)->toContain('"foo": "bar"');
+});
+
 it('can click on the page', function () {
     $command = Browsershot::url('https://example.com')
         ->click('#selector1')