Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement evaluate() (squashed commit) #185

Merged
merged 1 commit into from Apr 18, 2018
Merged

Implement evaluate() (squashed commit) #185

merged 1 commit into from Apr 18, 2018

Conversation

darron1217
Copy link
Contributor

Cleaned version of PR #181

@darron1217 darron1217 mentioned this pull request Apr 18, 2018
Closed
@freekmurze
Copy link
Member

Only thing missing now is a test. Could you add one?

@darron1217
Copy link
Contributor Author

I've added test named it_can_evaluate_page() already :)

@freekmurze freekmurze merged commit cc844c9 into spatie:master Apr 18, 2018
@freekmurze
Copy link
Member

Oh dear, I look right passed it.

Thanks for your awesome PR 👍

@darron1217 darron1217 deleted the evaluate branch April 19, 2018 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@darron1217 @freekmurze