Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set initial page Number for template Headers #632

Merged
merged 5 commits into from
May 9, 2022
Merged

Ability to set initial page Number for template Headers #632

merged 5 commits into from
May 9, 2022

Conversation

leonelvsc
Copy link
Contributor

Based on this comment puppeteer/puppeteer#3383 (comment) i've implemented and tested on my own the solution

@leonelvsc leonelvsc changed the title Hability to set initial pageNumber for templateHeaders Ability to set initial page Number for template Headers May 6, 2022
@leonelvsc
Update Browsershot.php
3975182 
More clear on the adds and subs
@leonelvsc
Copy link
Contributor Author

We could use the style injection to inject css at the headerTemplate as a parameter?

@freekmurze
Copy link
Member

Could you also add an example to the docs?

@leonelvsc
Copy link
Contributor Author

Done, i will leave to anyone else the inlining of css as a parameter for headers and footers

@freekmurze freekmurze merged commit 603f0c2 into spatie:main May 9, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@leonelvsc @freekmurze