Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Test against php 8.1 #246

Merged
merged 1 commit into from Oct 11, 2021
Merged

Test against php 8.1 #246

merged 1 commit into from Oct 11, 2021

Conversation

sergiy-petrov
Copy link
Contributor

No description provided.

@aidan-casey
Copy link
Collaborator

Hey @sergiy-petrov, thanks for the PR! Support for PHP 8.1 will be in version 4 which is currently in progress on the V4 branch, and includes CI testing for PHP 8.1. 🙂

@sergiy-petrov
Copy link
Contributor Author

@aidan-casey hey, thanks for the answer. What about merging it into V3 branch?

@brendt
Copy link
Contributor

brendt commented Oct 11, 2021

I'm not sure yet whether we'll support PHP 8.1 on the v3 branch… It might make early adoption easier so I'm leaning towards "yes". @aidan-casey what do you think?

@aidan-casey
Copy link
Collaborator

My initial thinking was that it would be best to not support 8.1 in V3 because:

  1. I don't think it's something we want to be supporting in the long run, and there may be some maintenance overhead. Especially with the significant differences between V3 and V4.
  2. With some of the features 8.1 provides, there are certain ideals we want to enforce in the package (e.g., readonly properties) that I would think we would want any version "supporting" 8.1 providing.

That said, it's just adding a version to the CI testing, so I could give a little too. 😅

@brendt
Copy link
Contributor

brendt commented Oct 11, 2021

I think our PHP 8.1 feature development should be focused only in v4, but if making v3 compatible doesn't take too much work, then why not? Since we're requiring "php": "^8.0", we're already saying we'll support 8.1.

So I'll merge this for now, we'll see how 8.1 development evolves in the coming weeks.

@brendt brendt merged commit 9ae7f9d into spatie:master Oct 11, 2021
@suyar
Copy link

suyar commented Feb 15, 2022

I think our PHP 8.1 feature development should be focused only in v4, but if making v3 compatible doesn't take too much work, then why not? Since we're requiring "php": "^8.0", we're already saying we'll support 8.1.

So I'll merge this for now, we'll see how 8.1 development evolves in the coming weeks.

Is there a release plan for V4 version?

@brendt
Copy link
Contributor

brendt commented Feb 16, 2022

Nothing concrete right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants