fix(dig): tell dig to not convert idn to locale string #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching a dns with special utf8 characters (xn--) dig will try by default to convert it, however it require some locales and since there are no env variable in the process defining it (LANG env var) it currently fails. This change make dig to no try to convert this domain in this case (which works for mostly all dns providers)
lyrixx
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching a dns with special utf8 characters (xn--) dig will try by default to convert it, however it require some locales and since there are no env variable in the process defining it (LANG env var) it currently fails. This change make dig to no try to convert this domain in this case (which works for mostly all dns providers)