Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Undefined constant DNS_CAA in windows platform #84

Merged
merged 3 commits into from
Dec 18, 2021
Merged

Fix Undefined constant DNS_CAA in windows platform #84

merged 3 commits into from
Dec 18, 2021

Conversation

ManojKiranA
Copy link
Contributor

No description provided.

@ManojKiranA
Copy link
Contributor Author

ManojKiranA commented Dec 16, 2021 •
edited

It would be nice to add windows operating system to github actions.

@freekmurze
Copy link
Member

Seems like the tests are failing for this one.

@ManojKiranA
Copy link
Contributor Author

will fix it ASAP

@freekmurze freekmurze merged commit 0bce09f into spatie:main Dec 18, 2021
@freekmurze
Copy link
Member

Thanks!

@freekmurze
Copy link
Member

It would be nice to add windows operating system to github actions.

Do all the tests pass when you run them on your local system?

@ManojKiranA ManojKiranA mentioned this pull request Dec 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ManojKiranA @freekmurze