Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial layout #1

Merged
merged 2 commits into from
Oct 26, 2017
Merged

Add initial layout #1

merged 2 commits into from
Oct 26, 2017

Conversation

willemvb
Copy link
Contributor

Changes

  • Added favicons
  • Added layout
  • Added scripts to focus on input, except when user highlights the results
  • Removed flash message

TBD

  • Do we need a simple warning when input is given, but incorrect / without results?
  • Responsive: scroll entire page, or just result horizontally?

freekmurze
freekmurze reviewed Oct 26, 2017
View reviewed changes
public/manifest.json
"theme_color": "#ffffff",
"background_color": "#ffffff",
"display": "standalone"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: every file should end with a newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a generated file from the favicon generator. I might forget that a few more times :)

@freekmurze freekmurze merged commit 9222008 into master Oct 26, 2017
@freekmurze
Copy link
Member

Seems ok to me, I'll merge and fix that nitpick myself.

@freekmurze freekmurze deleted the initial-layout branch October 26, 2017 13:16
@Vudubond Vudubond mentioned this pull request Feb 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze freekmurze left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willemvb @freekmurze