Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added docker-compose.yml with composer, test, psalm and format #44

Closed
wants to merge 1 commit into from

Conversation

dam-bal
Copy link
Contributor

@dam-bal dam-bal commented May 4, 2024

This will make local development easier

docker-compose run --rm composer install to install composer dependencies
docker-compose run --rm test to run tests
docker-compose run --rm psalm to run psalm
docker-compose run --rm format to format with php-cs-fixer

I had to add platform.php to composer.json as it will be using official composer image which might use different PHP version and there might be issues around dependencies.

@AlexVanderbist
Copy link
Member

Hi @dam-bal, thanks for your work on this package! We generally avoid including details about the development environment in our packages. This allows every contributor to decide how to want to run tests for themselves, and keeps us from having to maintain multiple docker-compose/setup scripts for every every package.

As an alternative, I'd propose keeping your own docker-compose.yml in the repo files but working with a global .gitignore to avoid accidentally committing it for this specific repo.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants