Improve speed (#24)

spatie · Oct 19, 2016 · 9c7b173 · 9c7b173
1 parent fc71bf6
commit 9c7b173
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/SortableTrait.php b/src/SortableTrait.php
@@ -53,11 +53,13 @@ public static function setNewOrder($ids, $startOrder = 1)
             throw new SortableException('You must pass an array to setNewOrder');
         }
 
+        $model = new static;
+
+        $orderColumnName = $model->determineOrderColumnName();
+        $primaryKeyColumn = $model->getKeyName();
+
         foreach ($ids as $id) {
-            $model = static::find($id);
-            $orderColumnName = $model->determineOrderColumnName();
-            $model->$orderColumnName = $startOrder++;
-            $model->save();
+            static::where($primaryKeyColumn, $id)->update([$orderColumnName => $startOrder++]);
         }
     }