Reorder soft-deleted records #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to reorder models that use the `SoftDeletes` trait. Fixes #31
freekmurze
requested changes
Nov 20, 2016
| * | ||
| * @return \Illuminate\Database\Query\Builder | ||
| */ | ||
| public function scopeAbove(Builder $query, int $position) |
There was a problem hiding this comment.
I don't like scopes being added that solely exist for internal working and will not be used publicly. Could you remove these?
There was a problem hiding this comment.
Sure, I thought these could be handy for public use, but I'll remove them right way.
freekmurze
approved these changes
Nov 20, 2016
|
Thanks! |
|
You're welcome! I owe you a postcard. 📮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to reorder models that use the
SoftDeletestrait.Fixes #31