Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filament v3 support - drop filament v2 support - add laravel v11 support #28

Merged
merged 7 commits into from Apr 1, 2024

Conversation

dinandmentink
Copy link
Contributor

@dinandmentink dinandmentink commented Mar 29, 2024

Drops filament v2 support and performs some related housekeeping.

Some notes:

  • First 2 commits taken from Adds laravel 11 support #26 by @mateusjunges. 2 after that rewritten. I have no access to that branch so simply cherrypicked the commits.
  • Filament introduces their own markdown editor based on EasyMDE, including file uploads: https://filamentphp.com/docs/3.x/forms/fields/markdown-editor. From what I see there are some cosmetic differences but almost complete feature parity. I might switch to the filamentphp default one for my own projects just to reduce a dependency.
  • There is a clash resulting in double icons. I fixed this clash by specifically removing the mask-image set by filament. Alternatively it's possible to actually let filament do these font inclusions and simply remove the font awesome dependency. I opted to solve the clash as it is less dependent on filament's own markdown editor implementation.

All in all, if someone can upgrade to filament v3 with this dependency they could probably remove it and switch to the filament provided one. In most cases anyway.

Screenshot from 2024-03-29 11-52-17

@freekmurze freekmurze merged commit 95f125c into spatie:main Apr 1, 2024
11 checks passed
@freekmurze
Copy link
Member

Thanks!

@freekmurze freekmurze mentioned this pull request Apr 1, 2024
@mateusjunges
Copy link

Thank you @dinandmentink! I didn't had the time to work on my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants