refactor

spatie · Apr 18, 2017 · f71b9bb · f71b9bb
1 parent 18a0be8
commit f71b9bb
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/DropboxAdapter.php b/src/DropboxAdapter.php
@@ -170,8 +170,6 @@ public function readStream($path)
      */
     public function listContents($directory = '', $recursive = false): array
     {
-        $listing = [];
-
         $location = $this->applyPathPrefix($directory);
 
         $result = $this->client->listContents($location, $recursive);
@@ -180,12 +178,12 @@ public function listContents($directory = '', $recursive = false): array
             return [];
         }
 
-        foreach ($result['entries'] as $object) {
-            $path = $this->removePathPrefix($object['path_display']);
-            $listing[] = $this->normalizeResponse($object, $path);
-        }
+        return array_map(function($entry) {
+            $path = $this->removePathPrefix($entry['path_display']);
+
+            return $this->normalizeResponse($entry, $path);
 
-        return $listing;
+        }, $result['entries']);
     }
 
     /**
@@ -217,7 +215,7 @@ public function getSize($path)
      */
     public function getMimetype($path)
     {
-        throw new LogicException('The Dropbox API v2 does not support mimetypes. Path: ' . $path);
+        throw new LogicException("The Dropbox API v2 does not support mimetypes. Given path: `{$path}`.");
     }
 
     /**
@@ -281,7 +279,9 @@ protected function normalizeResponse(array $response): array
             $result['bytes'] = $response['size'];
         }
 
-        $result['type'] = $response['.tag'] === 'folder' ? 'dir' : 'file';
+        $result['type'] = $response['.tag'] === 'folder'
+            ? 'dir'
+            : 'file';
 
         return $result;
     }