Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the dropbox provided content hash for flysystem checksum #92

Merged
merged 4 commits into from
Mar 13, 2023
Merged

use the dropbox provided content hash for flysystem checksum #92

merged 4 commits into from
Mar 13, 2023

Conversation

Gummibeer
Copy link
Contributor

closes #91

@freekmurze
Copy link
Member

Thanks!

It seems the tests are failing. Could you take a look at that?

@Gummibeer
Copy link
Contributor Author

It's the lowest tests failing as the ChecksumProvider interface was added in v3.7 but the package supports thephpleague/flysystem: "^2.0.4 || ^3.0.0", - should the minimum version be bumped? Unsure how else we could fix the problem?
And two tests have a warning.

@freekmurze
Copy link
Member

Let's bump the minimum versions indeed 👍

@Gummibeer
Copy link
Contributor Author

@freekmurze done and also fixed the deprecation warning. I assume that this would lead to a new major version of the package? 🤔
As it's BC in several ways.

@freekmurze
Copy link
Member

Thanks, I'll tag a new major version indeed.

@freekmurze freekmurze merged commit e71c079 into spatie:main Mar 13, 2023
@Gummibeer Gummibeer deleted the content-hash-checksum branch March 14, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants