Handle empty arrays passed to collections #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into issues in my Laravel project using laravel-fractal with this code:
I traced it back to this line in fractalistic:
If for whatever reason you end up passing an empty array as data, the ternary operator treats it as false, and
$instance->data
is set tonull
. Then$instance->dataType
is set"collection"
(since an array is passed to it). Eventually, this throws an exception:because it is trying to
foreach
over null (i.e. not an array).This PR (plus accompanying test) fixes it but not trying to do any transformation on the data that gets passed to
Fractal::create()
.