Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make jsonSerialize backward compatibile with PHP 7.4 #55

Merged
merged 1 commit into from Mar 20, 2022

Conversation

albertoarena
Copy link
Contributor

Issue

Solution

  • make return type compatible with PHP 7.4
  • add attribute #[\ReturnTypeWillChange] to prevent warnings in PHP 8.1

Tests

  • run successfully with PHP 7.4 and 8.1

Notes

src/Fractal.php Outdated Show resolved Hide resolved
@freekmurze freekmurze merged commit d9f256c into spatie:main Mar 20, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants