Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are failing #77

Closed
freekmurze opened this issue Dec 1, 2020 · 2 comments
Closed

Tests are failing #77

freekmurze opened this issue Dec 1, 2020 · 2 comments
Labels
bug good first issue help wanted

Comments

@freekmurze
Copy link
Member

One of the tests is failing on GitHub Actions. This should be fixed.
freekmurze pushed a commit that referenced this issue Dec 17, 2020
@Bapawe
Fix failing test on GitHub Actions after added php 8 support #77 (#78)
58ec17c 
* Fix external link to example.com on the link1 test page

* Update README.md
@Bapawe Bapawe mentioned this issue Dec 19, 2020
Merged
@Bapawe
Copy link
Contributor

Bapawe commented Dec 21, 2020

Since both fixes #78 and spatie/crawler#343 are merged, this issue should be fixed when the new patch version is being released of spatie/crawler v4 and composer.json is updated to use this new release.

@freekmurze
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freekmurze @Bapawe