New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use comments to allow proper loading of script #184

Merged

AlexVanderbist merged 1 commit into spatie:main from jaulz:patch-1

Feb 28, 2023

Contributor

jaulz commented Nov 2, 2022

Right now, whenever an error occurs it just shows me a lot of JavaScript code:

When I had a look at the DOM tree I saw that the script tag is suddenly closed:

It seems that the following line in the script is closing the tag too early:

;(c.innerHTML = '<script></script>'),

Using comments as a wrapper of the script it does not close the script and it's working perfectly fine.


          fix: use comments to allow proper loading of script

d1b6667

Member

AlexVanderbist commented Feb 28, 2023

Great catch! Thanks for the PR 👌

AlexVanderbist merged commit 09c6c4e into spatie:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment