-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable timeout
setting for the optimize
method
#187
Closed
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
889cb94
Enable `timeout` adjustment for the `OptimizerChain`
golubev 9e21acb
Merge branch 'main' into optimizers-configuration
golubev 327f999
Document new settings format for the `optimize` method
golubev 939e5ce
Update tests in the `OptimizeTest.php`
golubev da38736
Add `$timeout` argument to the `optimize()` method
golubev c866acb
Update documentation for the `optimize` method
golubev File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of adding a key in the array, let's add a dedicated parameter to specify timeout.
So this would use default timeout.
and this is how you would use a custom timeout:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @freekmurze 👋 Thanks for your feedback! I've updated the PR adding the
$timeout
parameter.It seems that the only option I had to implement this was to reuse that array key. It's being added under the hood when the
$timeout
parameter is being passed:The optimization options are always passed to the underlying layers with JSON serialization/deserialization:
That's why only a single array is available for any configuration.
Moreover, in a Laravel project with the
spatie/laravel-medialibrary
one might want to be able to configure a timeout for optimizers. This can be achieved with the help of theimage_optimizers
settings key in theconfig/media-library.php
adding e.g.'timeout' => 120
to the array:So I think the only possible way is to have both options available.