Image load fix #214
Merged
Image load fix #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
commented
Dec 18, 2023
| @@ -28,6 +28,10 @@ class Image implements ImageDriver | |||
| public function __construct(protected ?string $pathToImage = null) | |||
There was a problem hiding this comment.
Should this be a property on the Image object? It isn't actually used anywhere but it is protected so I guess removing is a BC break.
If we keep, Image::loadFile() should probably set this property as well?
kbond
commented
Dec 18, 2023
| it('it can load image from file', function () { | ||
| $image = Image::load(getTestJpg()); | ||
|
|
||
| expect($image->getHeight())->toEqual(280); |
There was a problem hiding this comment.
Without this fix, this test (getHeight()) produces the following error:
Typed property Spatie\Image\Drivers\Imagick\ImagickDriver::$image must not be accessed before initialization
|
That's indeed an oversight from our end. Thank you for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://twitter.com/freekmurze/status/1736801633986916639
When passing an image filename to
Image::__construct()andImage::load(), the file wasn't actually being loaded by the driver. The only way for it to work would be(new Image())->loadFile('file/path').