Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update GD driver #221

Merged
merged 7 commits into from
Dec 22, 2023
Merged

update GD driver #221

merged 7 commits into from
Dec 22, 2023

Conversation

ariaieboy
Copy link
Contributor

@ariaieboy ariaieboy commented Dec 22, 2023 •
edited

@freekmurze
Copy link
Member

It seems like the tests are failing. Could you take a look?

@ariaieboy
Copy link
Contributor Author

It seems like the tests are failing. Could you take a look?

the base64 function relies on the old implementation I need to fix that.

But right now I need to go I'll be back at night

@ariaieboy ariaieboy marked this pull request as draft December 22, 2023 09:46
@ariaieboy ariaieboy marked this pull request as ready for review December 22, 2023 13:01
@ariaieboy
Copy link
Contributor Author

@freekmurze I think it's ready now

@freekmurze freekmurze merged commit cf72c68 into spatie:main Dec 22, 2023
3 checks passed
@freekmurze
Copy link
Member

Thanks!

This was referenced Dec 22, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ariaieboy @freekmurze