Fixes causer not being set on ActivityLog when using a different guard other than Laravel's default #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnative
changed the title
Gnative
changed the title
Gummibeer
approved these changes
May 31, 2022
|
@Gummibeer Thanks to you and the Spatie team for the many packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that can cause the causer to not be applied to an ActivityLog if using any guard other than Laravels default 'web' guard.
Using
$this->authManager->getDefaultDriver()forces$this->authManager->guard($this->authDriver)->user()ingetDefaultCauserto use that guard. This change allows the authManager to return the authenticated user of the current guard.For example: When testing and using
Sanctum::actingAs($user), which uses the 'sanctum' guard, this would previously use the web guard and not return the authenticated user.I'm not sure how to apply testing for this.