Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tap method to ActivityLogger #472

Merged
merged 11 commits into from Jan 29, 2019
Merged

Add tap method to ActivityLogger #472

merged 11 commits into from Jan 29, 2019

Conversation

Gummibeer
Copy link
Collaborator

solves: #462

I've done some more things - because I wasn't able to do a tap() without an activity model instance I've changed all other methods to also work direct on the model. This has a major change, but not breaking, the properties are set on the model in the moment they are called and not just at the end.
I've also cleaned up some things (laravel 5.1 checks, type-hints).
All unit-tests still pass without any change, so I would say that nothing is broken and this just introduces the new feature.

@Gummibeer Gummibeer self-assigned this Jan 9, 2019
Copy link

@woliveirac woliveirac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

This feature was missing for me on what i wanted to do, but, now, it's working great.

Thank you !

@dam1r89
Copy link
Contributor

dam1r89 commented Jan 29, 2019

Just an update, we are running this branch on production right now 😉 Waiting to be merged.

@freekmurze
Copy link
Member

@Gummibeer looks good 👍
Could you also send a PR to docs with some examples of the new functionality?

@Gummibeer
Copy link
Collaborator Author

@dam1r89 thanks for the feedback. I'm in process to release v3.2.0 - so you will get a new stable release today.

@freekmurze I've already updated the CHANGELOG.md and will add it to the docs after I've released this feature.

@Gummibeer Gummibeer merged commit 2ed89a8 into master Jan 29, 2019
@Gummibeer Gummibeer deleted the ft-activity-tap branch January 29, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants