Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc blocks generated by IDE helper #956

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Conversation

gauravmak
Copy link
Contributor

@gauravmak gauravmak commented Sep 11, 2021

As per #950

Closes #951

@gauravmak
Copy link
Contributor Author

@Gummibeer Nothing to pressure but I am not sure if you were notified about this so just pinging.

@otilor
Copy link

otilor commented Dec 28, 2021

Have you run Larastan test on this and it fixes @Gummibeer issue?

@Gummibeer Gummibeer merged commit ddb9c51 into spatie:main Mar 4, 2022
@Gummibeer
Copy link
Collaborator

https://github.com/spatie/laravel-activitylog/releases/tag/4.4.1

@fabio-ivona
Copy link

It seems that this issue introduced these errors on larastan:

Call to method where() on an unknown class Spatie\Activitylog\Models\Illuminate\Database\Eloquent\Builder

anyone experienced something similar?

I think that's because of a missing \

@method static Illuminate\Database\Eloquent\Builder|Spatie\Activitylog\Models\Activity query()

shouldn't it be this?

@method static \Illuminate\Database\Eloquent\Builder|\Spatie\Activitylog\Models\Activity query()

@gauravmak
Copy link
Contributor Author

Thanks for pointing it out @fabio-ivona. Just added a PR with the fix

@gauravmak gauravmak deleted the patch-1 branch March 7, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static Analysis Support for Activity Model
4 participants