Allow for Route Model Binding #36
Conversation
Due to Route Model Binding acheived within `HasUuidPrimaryKey` trait, it is now preferable to overwrite the primary key using the method rather than the property so binding is still automatic.
|
Style CI appears to have lost it's mind over a curly brace and I cannot fix the issue! |
|
Thanks! It's a busy week so I'll probably review this next week, I'll keep you posted! |
|
Awesome, thanks @brendt |
|
@slashequip looks very nice! StyleCI does something strange indeed.. No worries, it won't be a blocker for merging this PR, if the problem keeps happening when merged, I'll let StyleCI submit a PR to master to fix it automatically. There's one thing I'm still worrying about, namely that we're still using two traits, one to add the binary uuid functionality, and one the allow you to override the key name/route binding. @freekmurze what do you think? I know we decided to split this functionality in the beginning of the package, but I don't really see the need to keep these two traits separate. |
|
We're going to merge this one and handle the trait stuff in another PR. Thanks @slashequip for the very clean PR! |
Provides a fix for #32 and allows for Laravel to automagically bind the model using the binary uuid.