fix: includes with data sometimes throw exceptions #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
I think it should also be fixed in
includeWhen
&includeUnless
, but I'm not sure why there is\n
inside those two and if it should also be insideinclude
andincludeIf
:laravel-blade-comments/src/Commenters/BladeCommenters/IncludeUnlessCommenter.php
Line 16 in b2a9f03
IMHO, it might be better to also unify the logic somehow, so there won't be a need to fix 2 places each time.
WDYT?